kinematics_plugin_loader port to ROS 2 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as #62 (comment), consider the changes please. |
mlautman
reviewed
Apr 9, 2019
|
|
||
| // ros::NodeHandle nh("~"); | ||
| //TODO (anasarrak): Add the appropriate node name for ROS2 | ||
| auto node = rclcpp::Node::make_shared("talker"); |
There was a problem hiding this comment.
This is a big TODO. Let's do this the right way now
There was a problem hiding this comment.
@mlautman any suggestion?
There was a problem hiding this comment.
I like the approach that was used for the controller manager where the node is passed in during initialization as it seems most flexible.
henningkayser
moved this from In progress
to Review in progress
in MoveIt2 Beta - Phase 1
|
Closed in favor of #107 |
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
* Fix headers * Port source and launch files of planning scene ROS API * Fix prompts and add xterm to launch * Update documentation * Add info about xterm * Remove debugging info and add todo * Update doc/planning_scene_ros_api/planning_scene_ros_api_tutorial.rst * Remove unnecessary note. * Fix prompts Co-authored-by: Marq Rasmussen <[email protected]> Co-authored-by: Jafar Abdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.