Port to ROS 2 #45
Port to ROS 2 #45
Conversation
update for colcon compilation
Still unfinished though
|
@rhaschke, any chance you can give a hand here pointing to the ros2 branch? I'll look at the conflicts ASAP. |
|
ros2 branch created. |
|
Solved conflicts, addressed some minor issues. @rhaschke and @davetcoleman can you please merge this? |
CMakeLists.txt
Outdated
| # if(BUILD_TESTING) | ||
| # find_package(rostest REQUIRED) | ||
| # add_rostest(test/srdf_parser.test) | ||
| # endif() |
There was a problem hiding this comment.
we should never disable tests, the likely hood that someone comes back and re-enables this is low due to human nature. tests are our friends
include/srdfdom/model.h
Outdated
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
| * Software License Agreement (BSD License) |
There was a problem hiding this comment.
please revert this types of changes, they are noise
| @@ -41,7 +41,7 @@ | |||
| #include <string> | |||
| #include <vector> | |||
| #include <utility> | |||
| #include <urdf/model.h> // TODO: replace with urdf_model/types.h in Lunar | |||
| #include <urdf/model.h> | |||
package.xml
Outdated
| <name>srdfdom</name> | ||
| <version>0.5.1</version> | ||
| <description>Parser for Semantic Robot Description Format (SRDF).</description> | ||
| <author email="[email protected]">Ioan Sucan</author> | ||
| <author email="[email protected]">Guillaume Walck</author> | ||
| <author email="[email protected]">Víctor Mayoral Vilches</author> |
There was a problem hiding this comment.
i don't think its fair to claim ownership over a package just because you ported it to ROS 2. for example, i have 5 commits and @rhaschke 17 but we haven't made ourselves authors of the package.
feel free to list yourself as a maintainer though!
| <name>srdfdom</name> | ||
| <version>0.5.1</version> | ||
| <description>Parser for Semantic Robot Description Format (SRDF).</description> | ||
| <author email="[email protected]">Ioan Sucan</author> | ||
| <author email="[email protected]">Guillaume Walck</author> | ||
| <author email="[email protected]">Víctor Mayoral Vilches</author> | ||
|
|
||
| <maintainer email="[email protected]">Dave Coleman</maintainer>maintainer> |
There was a problem hiding this comment.
im happy to be removed as a maintainer. notably, the XML appears broken for some reason
src/model.cpp
Outdated
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ |
There was a problem hiding this comment.
please avoid these changes in the future
test/test_parser.cpp
Outdated
| @@ -1,36 +1,36 @@ | |||
| /********************************************************************* | |||
There was a problem hiding this comment.
revert this file, there are no changes
package.xml
Outdated
| <build_depend>boost</build_depend> | ||
| <build_depend>cmake_modules</build_depend> | ||
| <build_depend>libconsole-bridge-dev</build_depend> | ||
| <build_depend>urdf</build_depend> | ||
| <build_depend>urdf_model</build_depend> |
There was a problem hiding this comment.
This package is not released in melodic or crystal. I believe it should be reverted
testing still needs further work
Fix library installation
Converting into a SHARED library
Export needed urdf
Remove not necessary commented lines
Direct to
ros2branch.