Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove String from PromitiveTypes #31

Closed
mrLSD opened this issue Jun 26, 2024 · 1 comment
Closed

Remove String from PromitiveTypes #31

mrLSD opened this issue Jun 26, 2024 · 1 comment
Assignees
@mrLSD
Labels
enhancement New feature or request type-system
Milestone
v0.4.2

Comments

@mrLSD
Copy link
Owner

mrLSD commented Jun 26, 2024

Description

PromitiveTypes represents only the most primitive types.

As potential pitfalls for backend implementation, String type mostly represents a complex type. For examples:

  • sized array[char]
  • unsized array[u8]
  • or other, including low-level LLVM representations.

To avoid that collision, String should be removed from PromitiveTypes.
@mrLSD mrLSD self-assigned this Jun 26, 2024
@mrLSD mrLSD added enhancement New feature or request type-system labels Jun 26, 2024
@mrLSD mrLSD added this to the v0.4.2 milestone Jun 26, 2024
@mrLSD mrLSD changed the title Remove String form PromitiveTypes Remove String from PromitiveTypes Jun 26, 2024
@mrLSD mrLSD mentioned this issue Jun 30, 2024
Merged
@mrLSD
Copy link
Owner Author

mrLSD commented Jun 30, 2024

Resolved: #32

@mrLSD mrLSD closed this as completed Jun 30, 2024
mrLSD added a commit that referenced this issue Aug 17, 2024
@mrLSD
Remove String from AST. Related to #31
020c58f
@mrLSD mrLSD mentioned this issue Aug 17, 2024
Merged
mrLSD added a commit that referenced this issue Aug 17, 2024
@mrLSD
Feat: Remove String from AST (#35)
52b54f9 
* Remove String from AST. Related to #31

* Updated to new clippy rules for - ast::ExpressionValue::_marker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrLSD mrLSD

Labels
enhancement New feature or request type-system
Projects
None yet
Milestone
v0.4.2
Development

No branches or pull requests
1 participant
@mrLSD