Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Remove String type #32

Merged
merged 5 commits into from
Jun 30, 2024
Merged

Feat: Remove String type #32

merged 5 commits into from
Jun 30, 2024

Conversation

mrLSD
Copy link
Owner

@mrLSD mrLSD commented Jun 30, 2024

Description

↪️ Implementation of #31

String type considerations

PromitiveTypes represents only the most primitive types.

As potential pitfalls for backend implementation, String type mostly represents a complex type. For examples:

  • sized array[char]
  • unsized array[u8]
  • or other, including low-level LLVM representations.

✅ To avoid that collision, String type was removed from PromitiveTypes.

@mrLSD mrLSD added the enhancement New feature or request label Jun 30, 2024
@mrLSD mrLSD added this to the v0.4.2 milestone Jun 30, 2024
@mrLSD mrLSD self-assigned this Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (76126a5) to head (e34402d).

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #32      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%     
===========================================
  Files            9        9              
  Lines         1964     1949      -15     
===========================================
- Hits          1964     1947      -17     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrLSD mrLSD merged commit 5437f8e into master Jun 30, 2024
3 of 4 checks passed
@mrLSD mrLSD deleted the feat/remove-string-type branch June 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant