Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] find_outlier_trials() #1

Merged
merged 1 commit into from
Mar 13, 2019
Merged

[FIX] find_outlier_trials() #1

merged 1 commit into from
Mar 13, 2019

Conversation

croyen
Copy link
Contributor

@croyen croyen commented Mar 13, 2019

There is a bug find_outlier_trials compatible when a list of thresholds is passed.

@nbara nbara changed the title Fit for find_outlier_trials [FIX] find_outlier_trials() Mar 13, 2019
@nbara nbara self-requested a review March 13, 2019 14:55
@nbara nbara added the bug Something isn't working label Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   51.89%   51.89%           
=======================================
  Files          15       15           
  Lines        1453     1453           
=======================================
  Hits          754      754           
  Misses        699      699
Impacted Files Coverage Δ
meegkit/utils/denoise.py 31.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ca433...9a08ef3. Read the comment docs.

@nbara
Copy link
Owner

nbara commented Mar 13, 2019

thanks @croyen

@nbara nbara merged commit c6672ba into nbara:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants