-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add additional mCCA example #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 22 22
Lines 2367 2367
=======================================
Hits 1867 1867
Misses 500 500 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi, I'm happy to see that my pr has passed all but one of the tests. With regards to the test that failed, I'm not sure I can fix it on my end. Here is the error:
Best, |
Hey John, thanks for this! I will have a look asap. The doc build job should be an easy fix |
Hi @johnkylecooper, the example looks great. FWIW, you don't need to generate both the Just do you code in the .py file, and run Again, thanks for the contribution. I don't use the code in PS: the doc build fails it comes from a fork. It's a CI bug, nothing to do with your example. |
Thanks! :)
Also, thanks for the tips! :) Going to delete my branch and delete the fork now. Best, |
Hi, thanks for the amazing toolbox! I would like to add an additional example using the MCCA implementation in python-meegkit since I was initially having trouble understanding how the implementation is used to extract an underlying signal from concatenated data matrices. Maybe this will help others when applying more complex signals to the MCCA function.
The example is example #1 taken from de Cheveigné et al., 2018. I believe that the code is correct and reproduces the results shown in Figure 4. Note: this is my first pull request, so I apologize in advance if anything isn't properly implemented.