Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Show asset collections and tag for read-only asset sources #3481

Conversation

kdambekalns
Copy link
Member

Asset sources have a method isReadOnly() to tell whether they are read-only or not. A read-only asset source does not allow their content to be changed.

With this change, that read-only state is no longer coupled to the display of asset collections and tags in the media browser. Asset sources thus are free to implement a "connection" to asset collections and tags in any reasonable way.

Fixes #3480

Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good :)
Thanks for the adjustment

Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good old Fluid templates 😉

@markusguenther markusguenther merged commit fe15906 into neos:master Nov 17, 2021
@markusguenther markusguenther moved this from Reviews Needed to Done in Neos & Flow 7.3 LTS Release Board Nov 22, 2021
@kdambekalns kdambekalns deleted the task/decouple-assetcollections-tags-from-readonly branch February 3, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of asset collections and tags is bound to read-only status of an asset source
3 participants