BUGFIX: Allow adding first asset collection again #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a regression in 0143d67 which prevents adding an asset collection if there was none before as the form was not rendered.
markusguenther
approved these changes
Feb 24, 2022
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This fix resolves a regression in 0143d67 (#3481)
which prevents adding an asset collection if there was none before
as the form was not rendered.
How I did it
Move collection creation form outside of condition which checks for the existence of any least one collection.
How to verify it
Try to add a new collection inside the media module in a fresh Neos without any collections
Checklist