Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #12

Merged
merged 37 commits into from
Jul 18, 2022
Merged

Develop #12

merged 37 commits into from
Jul 18, 2022

Conversation

drnimbusrain
Copy link
Member

Adding canopy parameter control, canopy constant module, and more flexible namelist control for additional user options.

angehung5 and others added 17 commits July 12, 2022 15:18
@angehung5
Add files via upload
a8ba7a4 
add surface roughness length (Z0)
domain: 30-40N, 80-100W
@angehung5
Update canopy_driver.F90
9cec3d2 
change the section of reading input variables
@zmoon
Gitignore the output files
a600abd
@zmoon
nlat/nlon for current domain
8ba0b1f
@zmoon
Close input files after reading
4e83915
@angehung5
Add files via upload
5ba5a72
@angehung5
Add files via upload
7867655
@drnimbusrain
Merge pull request #10 from angehung5/add_variables
952e619 
Add variables
@drnimbusrain
Initial commit of a vegetation type depdendent canopy_parm.
8c81e3a
@drnimbusrain
Added canopy constants module and fixed bug in canopy_parm
c426781
@drnimbusrain
Initial commit of feature branch for namelist control.
92fc943
@drnimbusrain
Updated bug in allocation of canopyTOP
d77014e
@drnimbusrain
Cleaned up commented lines...
0af4f31
@drnimbusrain
Added ifcanopywind namelist option
9f75bb1
@drnimbusrain
Merge pull request #11 from noaa-oar-arl/feature/namelist_control
28c2cf6 
Feature/namelist control
@drnimbusrain
Fixed flameh =0 bug
334e30e
@drnimbusrain
Moved flameh from canopy_parm to namelist and fixed bugs.
7c97b50
@drnimbusrain drnimbusrain requested a review from zmoon July 18, 2022 15:25
zmoon
zmoon requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@zmoon zmoon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

I checked many of the constants, for value and precision.

canopy_const_mod.F90 Outdated Show resolved Hide resolved
canopy_const_mod.F90 Show resolved Hide resolved
canopy_const_mod.F90 Outdated Show resolved Hide resolved
canopy_files_mod.F90 Outdated Show resolved Hide resolved
canopy_driver.F90 Outdated Show resolved Hide resolved
canopy_const_mod.F90 Outdated Show resolved Hide resolved
canopy_const_mod.F90 Outdated Show resolved Hide resolved
canopy_const_mod.F90 Show resolved Hide resolved
canopy_const_mod.F90 Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
drnimbusrain and others added 11 commits July 18, 2022 13:22
@drnimbusrain
Updated Makefile for OBJ readability.
a5a8c12
@drnimbusrain @zmoon
Update canopy_const_mod.F90
88650aa 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
d912bd9 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
e7cf7e3 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
a027e18 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
f181ee0 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
2b3de00 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
5bbd46d 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
669e909 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
2e6cf79 
Co-authored-by: Zachary Moon <[email protected]>
@drnimbusrain @zmoon
Update canopy_const_mod.F90
8bd737a 
Co-authored-by: Zachary Moon <[email protected]>
drnimbusrain
drnimbusrain commented Jul 18, 2022
View reviewed changes
Copy link
Member Author

@drnimbusrain drnimbusrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Zach for your review and suggestions. I have made the necessary changes/commits.

Makefile Outdated Show resolved Hide resolved
canopy_const_mod.F90 Show resolved Hide resolved
canopy_const_mod.F90 Show resolved Hide resolved
canopy_files_mod.F90 Outdated Show resolved Hide resolved
canopy_driver.F90 Outdated Show resolved Hide resolved
canopy_parm_mod.F90 Outdated Show resolved Hide resolved
canopy_parm_mod.F90 Outdated Show resolved Hide resolved
canopy_wind_mod.F90 Outdated Show resolved Hide resolved
drnimbusrain
drnimbusrain commented Jul 18, 2022
View reviewed changes
Copy link
Member Author

@drnimbusrain drnimbusrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made additional commits per Zach's review.

@drnimbusrain @zmoon
Update canopy_const_mod.F90
312546e 
Co-authored-by: Zachary Moon <[email protected]>
drnimbusrain
drnimbusrain commented Jul 18, 2022
View reviewed changes
Copy link
Member Author

@drnimbusrain drnimbusrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve commit.

@drnimbusrain
Copy link
Member Author

@zmoon Do you now approve these changes?

@drnimbusrain drnimbusrain requested a review from zmoon July 18, 2022 17:55
zmoon
zmoon approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it

@drnimbusrain drnimbusrain merged commit bcb699b into main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoon zmoon zmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drnimbusrain @zmoon @angehung5