[WIP] add nan to lookup.json

[mcollina]

I've added nan to lookup.json. I think it should be there, and we should do our best to keep this up to date and supported.

Checklist

• npm test passes
• tests are included
• documentation is changed or added
• contribution guidelines followed
  here

[targos]

It agree it should be there, but right now citgm nan fails on all supported release lines.

[mcollina]

This seems a major problem and a failure on our side.
I fear NAN might be using some of the deprecated V8 APIs.

[codecov-io]

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #659   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          26       26           
  Lines         823      823           
=======================================
  Hits          777      777           
  Misses         46       46

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715ffe0...c98f1e4. Read the comment docs.

[richardlau]

It agree it should be there, but right now citgm nan fails on all supported release lines.

The test bindings need to be built: https://github.com/nodejs/nan#tests

Tests

To run the NAN tests do:

npm install
npm run-script rebuild-tests
npm test

Or just:

npm install
make test

I don't think we currently have a way in lookup.json of accommodating this.

[richardlau]

It agree it should be there, but right now citgm nan fails on all supported release lines.

The test bindings need to be built: https://github.com/nodejs/nan#tests

Tests

To run the NAN tests do:

npm install
npm run-script rebuild-tests
npm test

Or just:

npm install
make test

I don't think we currently have a way in lookup.json of accommodating this.

My attempt: #696

[targos]

Superseded by #696