-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scripts option to lookup table #696
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 94.64% 94.76% +0.11%
==========================================
Files 27 27
Lines 859 878 +19
==========================================
+ Hits 813 832 +19
Misses 46 46
Continue to review full report at Codecov.
|
Rerun with fixes for Node.js 6 and 8 (avoid use of Almost clean on 6 and 8 (linux-s390x ran on a rebuilt host which appears to be missing Building the > node-gyp rebuild --msvs_version=2015 --directory test
C:\workspace\citgm-smoker-nobuild\workspacecitgm-smoker-nobuild\citgm_tmp\54a49ab2-3776-45c0-a8d3-9b5cbc5e27b4\nan>if not defined npm_config_node_gyp (node "C:\workspace\citgm-smoker-nobuild\node\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild --msvs_version=2015 --directory test ) else (node "C:\workspace\citgm-smoker-nobuild\node\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --msvs_version=2015 --directory test )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
C:\workspace\citgm-smoker-nobuild\workspacecitgm-smoker-nobuild\citgm_tmp\54a49ab2-3776-45c0-a8d3-9b5cbc5e27b4\nan\test\build\accessors.vcxproj(20,3): error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
... |
@SimenB Is that also what you need for Jest? |
Yes, perfect! |
If set, "scripts" specifies the scripts from the module's package.json to run instead of the default "test".
@richardlau can we go ahead with this? |
I released a patch release just before landing this. Currently waiting for Travis CI to complete on the rebased #706 and then I'll land that too and release a new minor that includes this PR. |
If set, "scripts" specifies the scripts from the module's package.json
to run instead of the default "test".
Allows
nan
to be added (second commit).Checklist
npm test
passeshere