Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #147 - Gracefully handle non-existent tags #567

Conversation

hilarysk
Copy link
Contributor

@hilarysk hilarysk commented May 8, 2024

What does this PR do?

  1. Adds a tag index page
  2. Adds a link to the tags index page in the header
  3. Adds tags to the db seeds file
  4. Adds a test for the new controller action
  5. Adds new factory for tags
  6. Adds a note on the tag show page if there aren't any proposals currently associated with that tag
Why was this work done? Is there a related Issue?

Addresses Issue #147

Where should a reviewer start?

Probably the Tags Controller

Are there any manual testing steps?

Run the new seeds (note: this is destructive; if you have local data to keep, you can manually run the tag creation section of the seeds file). Navigate to "Tags" from the header.

Screenshots

Screen Shot 2024-05-08 at 11 22 19 AM Screen Shot 2024-05-08 at 11 46 06 AM

Deployment instructions

N/A

Database changes

N/A

New ENV variables

N/A

@nodunayo nodunayo merged commit 1f84348 into nodunayo:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants