Issue #564 - No clear indicator in the header re: what page you're currently viewing #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilarysk
force-pushed
the
hilarysk/issue-564-no-clear-indicator-in-the-header-re-what-page-youre-currently-viewing
branch
from
1635e92
to
887976f
Compare
hilarysk
commented
May 8, 2024
| } | ||
|
|
||
| .navigation a { | ||
| color: #9b9b9b; | ||
| margin-left: 20px; | ||
| color: #757575; |
There was a problem hiding this comment.
darkens slightly to meet color contrast guidelines
hilarysk
commented
May 8, 2024
| @@ -141,9 +164,15 @@ fieldset.fieldset legend { | |||
| margin-right: 0; | |||
| } | |||
|
|
|||
| .navigation ul li.active { | |||
| border-bottom: 0; | |||
| font-weight: 500; | |||
There was a problem hiding this comment.
The underline looked odd on responsive, so I switched to bold for smaller screens:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I didn't realize with forking that you can't branch off a different forked branch, so #567 should be merged first (this PR is branched from that PR).
Why was this work done? Is there a related Issue?
Issue #564
Where should a reviewer start?
Probably the new Navigation Helper.
Are there any manual testing steps?
Load the site locally and click around.
Screenshots
Deployment instructions
N/A
Database changes
N/A
New ENV variables
N/A