Improve speed of Normal Space filtering #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more efficient sampling method instead of rejection sampling. Improves runtime speed and determinism by not attempting to sample low probability events. Remove empty bins and randomly select from only the available bins. Points are added into each bin initially in a random order, and are now popped off the back of a list of points inside the bucket.
|
Thanks for the effort. It's really appreciated! We'll look at this PR more in details at the end of this week. |
|
@jsburklund Wow, your implementation is really faster than the old one! It will be merged soon. Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the speed of Normal Space binning and selection.
Use a more efficient sampling method instead of rejection sampling. Improves runtime speed and determinism by not attempting to sample low probability events. Remove empty bins and randomly select from only the remaining available bins. Points are added into each bin initially in a random order, and are now popped off the back of a list of points inside the bucket.