Fix out-of-bounds access #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pomerlef
reviewed
Jun 7, 2020
|
ok to test |
|
@jlblancoc Good eye 👁️ Did you use sampled covariances in your work? How was your experience with them? |
Merits should actually go to g++10 and properly-set flags ;-)
Actually not, sorry... RandomSamplingDataPointsFilter and SurfaceNormalDataPointsFilter worked really well, so didn't tested the other methods (at least, so far). |
|
We've test it over here: https://arxiv.org/pdf/1810.01666.pdf if you're interested. Hopefully the bug didn't inluenced too much the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug, right? :-)
We cannot write into
Vector3[3].