Add seed to Random sampling filter #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
Thank you!!! |
|
Btw, an idea for follow-up. In those unit tests that rely on randomness, we could record the random seed, such that we can still 'test the filters randomly' (random is, ultimately, their intended behavior), but still be able to debug test failures. See http://google.github.io/googletest/reference/testing.html#Test::RecordProperty |
|
ok to test |
|
Took me a while to pin point the error in the log: The ASL CI server is not behaving properly and I'm not sure who is maintaining that anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the seed parameter, already present for other filters, such as Maximum point count or NSS. I think that eventually this parameter should be added to all filters that contain randomness to allow a fair comparison between e.g. sampling methods.