Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle libnabo config mode #513

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

sloriot
Copy link
Contributor

@sloriot sloriot commented May 31, 2023

An alternative would be to set libnabo_INCLUDE_DIRS and libnabo_LIBRARIES in libnabo-targets.cmake

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

pomerlef commented Jun 7, 2023

ok to test

@pomerlef
Copy link
Collaborator

pomerlef commented Jun 7, 2023

@sloriot I'm missing the intent of the PR. Can you describe what was not working or what you want to improve?

@sloriot
Copy link
Contributor Author

sloriot commented Jun 7, 2023

I wanted to have the config mode of cmake working with libnabo. Indeed, if you use the config mode then libnabo will be reported as found but the cmake variables that pointmatcher expects are not set.

As a side note, I also noticed that it is not possible to use pointmatcher with cmake without doing make install which does not seems to be ideal for people without root access to their computer. Last point, I don't understand why libnabo is not part of the dependency libs of pointmatcher target like you did with boost. I hacked it with CGAL/cgal#7498 but if you are interested in getting some cmake update I can submit another PR to address both issues.

@pomerlef
Copy link
Collaborator

pomerlef commented Jun 7, 2023

Any link with #514? and of course, if you want to propose another PR we will gladly review it!

@sloriot
Copy link
Contributor Author

sloriot commented Jun 7, 2023

Any link with #514? and of course, if you want to propose another PR we will gladly review it!

It indeed seems to be the same issue that my hack fixes at CGAL level. Since there was no such error in the past, I guess that some libnabo API is now exposed in pointmatcher (thus the need for the link).

@pomerlef
Copy link
Collaborator

pomerlef commented Jul 5, 2023

Thanks @sloriot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants