Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally noticed this bug when unit testing an NDT-inspired octree sampling method.
The current octree sampling implementation takes into account the situation when the indexed point was already processed; see this example:
However, we don't know whether
mapidx[d]
doesn't again point to an index that was also processed. What actually needs to be done, is to propagate all the changes that were made on all previously used indexes ofmapidx
. So in this PR, I replaced the above code example and similar byI haven't had time to check other Octree implementations and see how they deal with this situation.
Naturally, the use of the while cycle slows down the execution. There's probably a more clever solution using pointers?