-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Build system improvements and fixes #546
Merged
RedLeader962
merged 26 commits into
develop
from
dev-refactor-simplify-the-dockerfile-implementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
Dec 18, 2023
Merged
fix: Build system improvements and fixes #546
RedLeader962
merged 26 commits into
develop
from
dev-refactor-simplify-the-dockerfile-implementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y set the default tests directory from within an interactive session
…intmatcher at root to resolve path, top dir name and set prompt acronym for N2ST
…ementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
…ted `pull_request_template.md` references
…bash`; `refactor tests/` dir; add helper fct;
…ementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
@boxanm @simonpierredeschenes @aguenette Sorry guys for the review request. Because of the version bump in //! version of the Pointmatcher library as string
#define POINTMATCHER_VERSION "1.4.0"
//! version of the Pointmatcher library as an int
#define POINTMATCHER_VERSION_INT 10400 |
…ementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Add various github tools such as code owner for protected branch and pull-request template.
Improve/fix build-system and refactor out to NBS logic that is generalisable.
Improve the libpointmatcher-build-system documentation.
Changes and type of changes:
Doc
README.md
, fix typo, mod changelog version to 1.4.0.README.md
update. Added dev related instructionsREADME.md
improvement to the Contributing sectionpull_request_template.md
references
Refactoring
them. Add bats test
.env.libpointmatcher
at root toresolve path, top dir name and set prompt acronym for N2ST
1.4.0
Build system
Bug fix
tests_docker_interactive/
, update run configuration setup,restructure directories
lpm_crawl_dependencies_build_matrix.bash
not passing argumentproperly to sub-shell
make run_bats_core_test_in_n2st.bash
script able to automatically set the default testsdirectory from within an interactive session
Other
lpm_crawl_libpointmatcher_build_matrix.bleeding.bash
;refactor tests/
dir; add helper fct;
norlab-ulaval/dev-refactor-libpointmatcher-build-system-logic-to-norlab-build-system-submodule-NMO-398
Checklist:
Code related
README.md)
PR creation related
base ref
branch is set to thedevelop
branch (the build-system won't be triggered otherwise)develop
branch (the build-system will reject it otherwise)PR description related
feat
fix
docs
style
refactor
perf
test
build
ci
chore
revert
<type>!
# <issue-id>
if changes are of typefix
Note for repository admins
Release PR related
push/merge
on the default branch (ie:master
) and therelease
branch.draft
mode until all the release reviewers are ready to push the release.release
->master
branch is created (not in draft mode),