-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement libpointmatcher turnkey install scripts for user who have cloned the repo #547
Conversation
… TeamCity badge; cleaned html formating
…ementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
…have cloned the repo [NMO-353] - feat: implemented a user side installer script for libpointmatcher dependencies and libpointmatcher (it call the build system version under the hood) - fix: solved the logic for passing CMAKE_INSTALL_PREFIX flag to the sourced installer sub-script - feat: added a `--test-run` flag plus dry-run logic to `lpm_install.*.bash` script for efficiently testing `lpm_install.*.bash` and `libpointmatcher_[dependencies_]installer.bash` scripts - fix: solved the build system installer git checkout tag landing out of the if clause on the parent level - test: added build system installer related bats test - test: added user installer related bats test - test: added `.env.libpointmatcher` bats test #### Others - ci(codeowner): update and clean entries - chore: added convenient run configuration for script help menu - update NBS and N2ST submodule to latest
…to stder on error [NMO-460]
…utput redirection to stder on error [NMO-457]
|
@pomerlef For your info, the review request was triggered because I've edited the root |
Description
Summary:
Implemented a scripts for easily install both the dependencies and libpointmatcher on unbuntu. Both script use the build-system install script logic under the hood. All script including the build-system have their corresponding test in bats. Also fixed sevarl bugs related to build-system install scripts.
Changes and type of changes:
issue NMO-353 and NMO-460 on NorLab youtrack
Features
--test-run
flag plus dry-run logic tolpm_install.*.bash
script for efficiently testinglpm_install.*.bash
andlibpointmatcher_[dependencies_]installer.bash
scriptsBug fix
Test
.env.libpointmatcher
bats testOthers
Checklist:
Code related
README.md)
PR creation related
base ref
branch is set to thedevelop
branch (the build-system won't be triggered otherwise)develop
branch (the build-system will reject it otherwise)PR description related
feat
fix
docs
style
refactor
perf
test
build
ci
chore
revert
<type>!
# <issue-id>
if changes are of typefix
Note for repository admins
Release PR related
push/merge
on the default branch (ie:master
) and therelease
branch.draft
mode until all the release reviewers are ready to push the release.release
->master
branch is created (not in draft mode),