Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum libnabo version in CMakeLists.txt #567

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

boxanm
Copy link
Collaborator

@boxanm boxanm commented May 7, 2024

I removed the minimum libnabo version that used to be set in MatchersImpl.h and moved it to CMakeLists.txt instead.

@boxanm boxanm requested a review from RedLeader962 as a code owner May 7, 2024 23:23
@boxanm
Copy link
Collaborator Author

boxanm commented May 7, 2024

The compiling tests are expected to fail because libnabo version used to be set in CMakelists.txt with a regex reading a header file that hasn't been updated since 1.0.7 (see this line). We first need to merge this PR which reads package.xml instead.

aguenette
aguenette previously approved these changes May 14, 2024
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants