Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing build due to deprecated boost::filesystem functions #577

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix failing build due to deprecated boost::filesystem functions #577

merged 1 commit into from
Jul 2, 2024

Conversation

boxanm
Copy link
Collaborator

@boxanm boxanm commented Jul 1, 2024

Description

Summary:

Addresses #574

Changes and type of changes (quick overview):

  • Replaced deprecated boost::filesystem::complete with boost::filesystem::absolute
  • Replaced deprecated boost::filesystem::extension(path) with path.extension().string()
  • Added a check if a filename contains an extension

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@boxanm boxanm merged commit 9a9d969 into develop Jul 2, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpierredeschenes simonpierredeschenes simonpierredeschenes approved these changes

@aguenette aguenette Awaiting requested review from aguenette aguenette is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boxanm @simonpierredeschenes