-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leave boost filesystem #581
Conversation
The build is failing on Bionic because we have an outdated compiler. This thread has an explanation. sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt update
sudo apt install gcc-9 g++-9 |
- Add command to set GCC and G++ 9 as bionic alternatives Issue NMO-585 and PR #581
@boxanm Does it mean that we can drop the Boost install step from n2st::teamcity_service_msg_blockOpened "Install Libpointmatcher dependencies › Boost"
# https://www.boost.org/doc/libs/1_79_0/more/getting_started/unix-variants.html
sudo apt-get update &&
sudo apt-get install --assume-yes "${APT_FLAGS[@]}" \
libboost-all-dev &&
sudo rm -rf /var/lib/apt/lists/*
n2st::teamcity_service_msg_blockClosed |
@boxanm So updating the LPM dependencies is a two steps process:
I'm updating the build system dependencies install script in a separate branch |
@RedLeader962 We still need boost for other stuff, for now I just replaced the broken dependency on boost::filesystem. Eventually I'd like to remove boost completely but that might be a longer project. |
|
Description
Summary:
Minor changes to the docs (mostly replacing old eth links with norlab).
I removed the
boost::filesystem
dependency completely from libpointmatcher and replaced it with the equivalentstd::filesystem
. Some of the boost methods have been deprecated for a long time and started causing compilation issues and unexpected behaviors on newer platforms.Changes and type of changes (quick overview):
boost::filesystem
dependencyChecklist:
Code related
(i.e.: function, class, script header, README.md)
(Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)
PR creation related
base ref
branch is set to thedevelop
branch(the build-system won't be triggered otherwise)
develop
branch(the build-system will reject it otherwise)
PR description related
# <issue-id>
if changes are of typefix
(See commit_msg_reference.md for details)