Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: v1.1.1 #412

Closed
3 of 6 tasks
JeyJeyGao opened this issue May 31, 2024 · 5 comments
Closed
3 of 6 tasks

vote: v1.1.1 #412

JeyJeyGao opened this issue May 31, 2024 · 5 comments

Comments

@JeyJeyGao
Copy link
Contributor

JeyJeyGao commented May 31, 2024

Release

Note

This release doesn't include the #379 as this is a patch release.

The commit 94a0e13 was generated by the following steps:

  1. Checked out a new branch release-1.1 from main branch
  2. Reverted feat: add support for signing blob #379 in PR revert: "feat: add support for signing blob (#379)" #411

Vote

We need at least 4 approvals from 6 maintainers to release notation-go v1.1.1.

Changes

Full Changelog: v1.1.0...94a0e13

JeyJeyGao added a commit that referenced this issue May 31, 2024
Revert:
- reverted #379 
- reverted test cases: `TestSignOptsMissingSignatureMediaType` and
`TestSignOptsUnknownMediaType`, introduced in #405

Test:
- added test for `log` package to pass 80% coverage target

This reverts commit ec42378.


Resolves part of #412 
Signed-off-by: Junjie Gao <[email protected]>

---------

Signed-off-by: Junjie Gao [email protected]
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
Copy link
Contributor Author

LGTM

3 similar comments
@shizhMSFT
Copy link
Contributor

LGTM

@Two-Hearts
Copy link
Contributor

LGTM

@priteshbandi
Copy link
Contributor

LGTM

@JeyJeyGao
Copy link
Contributor Author

Closed this vote as v1.1.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants