Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage to 80% #405

Merged
merged 18 commits into from
May 28, 2024
Merged

test: improve test coverage to 80% #405

merged 18 commits into from
May 28, 2024

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented May 23, 2024 •
edited
Loading

Test:

  • improved test coverage to over 80.16%

Fix:

  • added ORAS copy library to copy the OCI Layout test data to a temporary directory and avoid generating test time temporary files in the repository directory.

@JeyJeyGao
fix: error message for dangling reference index
da398fe 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
test: add unit test
269845c 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
Merge remote-tracking branch 'upstream/main' into fix/dangling_referr…
7ab5919 
…er_error_message
@JeyJeyGao
fix: use remote.ReferrersError type
d28f182 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
test: add test cases
6664b27 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
test: add test cases
51a3e6b 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: add license
d8c8f29 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
test: add test cases
d444452 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
test: update test cases
83b28aa 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
12dfced 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update code
7647253 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fiX: update code
519099d 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
test: improve test coverage
49fa8a2 
Signed-off-by: Junjie Gao <[email protected]>
@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (9ff1891) to head (39452a5).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   73.43%   80.15%   +6.72%     
==========================================
  Files          24       31       +7     
  Lines        2507     2172     -335     
==========================================
- Hits         1841     1741     -100     
+ Misses        526      302     -224     
+ Partials      140      129      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
fix: update test
7812144 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao changed the title test: improve test coverage test: improve test coverage to 80% May 23, 2024
@JeyJeyGao
fix(test): update
25d37ee 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao closed this May 24, 2024
@JeyJeyGao JeyJeyGao reopened this May 24, 2024
@JeyJeyGao JeyJeyGao changed the title test: improve test coverage to 80% test: improve test coverage to 80.16% May 24, 2024
@JeyJeyGao JeyJeyGao changed the title test: improve test coverage to 80.16% test: improve test coverage to 80% May 24, 2024
shizhMSFT
shizhMSFT reviewed May 24, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@JeyJeyGao
fix: simplify Copy function
cdc359e 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: simplify code
39452a5 
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
shizhMSFT approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts mentioned this pull request May 27, 2024
Merged
priteshbandi
priteshbandi approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit b8508d0 into notaryproject:main May 28, 2024
9 checks passed
JeyJeyGao added a commit that referenced this pull request May 29, 2024
@JeyJeyGao
test: improve test coverage to 80% (#405)
9f89059 
Test:
- improved test coverage to over 80.16%

Fix:
- added ORAS copy library to copy the OCI Layout test data to a
temporary directory and avoid generating test time temporary files in
the repository directory.

---------

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao mentioned this pull request May 29, 2024
Closed
6 tasks
JeyJeyGao added a commit to JeyJeyGao/notation-go that referenced this pull request May 31, 2024
@JeyJeyGao
revert: test cases introduced in notaryproject#405
bb0974d 
Signed-off-by: Junjie Gao <[email protected]>
This was referenced May 31, 2024
Merged
Closed
JeyJeyGao added a commit that referenced this pull request May 31, 2024
@JeyJeyGao
revert: "feat: add support for signing blob (#379)" (#411)
94a0e13 
Revert:
- reverted #379 
- reverted test cases: `TestSignOptsMissingSignatureMediaType` and
`TestSignOptsUnknownMediaType`, introduced in #405

Test:
- added test for `log` package to pass 80% coverage target

This reverts commit ec42378.


Resolves part of #412 
Signed-off-by: Junjie Gao <[email protected]>

---------

Signed-off-by: Junjie Gao [email protected]
Signed-off-by: Junjie Gao <[email protected]>
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeyJeyGao @priteshbandi @shizhMSFT @Two-Hearts