-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add signingkeys.json validation check #246
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 73.35% 69.56% -3.79%
==========================================
Files 23 23
Lines 1775 1909 +134
==========================================
+ Hits 1302 1328 +26
- Misses 375 483 +108
Partials 98 98
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
efa37bf
to
29fb75a
Compare
cef7edd
to
a0e70c8
Compare
Signed-off-by: Pritesh Bandi <[email protected]>
Fix error message: Instead of printing bytes in error message convert them to string. Signed-off-by: Pritesh Bandi <[email protected]>
This PR adds examples for notation-go sign and verify including fully functional examples (can run in go playground) for local sign and local verify. Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
…ryproject#248) Signed-off-by: Pritesh Bandi <[email protected]>
notaryproject#247) Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
f908baf
to
b470363
Compare
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We could wait for Shiwei in case he has extra comments on the PR.
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change to validate signingkeys are valid(unique name) for both read and write operation. Signed-off-by: Pritesh Bandi <[email protected]>
This PR depends on notaryproject/notation-go#246 so please review notaryproject/notation-go#246 first. Signed-off-by: Pritesh Bandi <[email protected]
Change to validate signingkeys are valid(unique name) for both read and write operation.
Signed-off-by: Pritesh Bandi [email protected]