feat: add local sign/verification for OCI layout directory #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
patrickzheng200
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
patrickzheng200
changed the title
Signed-off-by: Patrick Zheng <[email protected]>
patrickzheng200
changed the title
shizhMSFT
changed the title
patrickzheng200
changed the title
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Mar 31, 2023
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Apr 3, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
|
@priteshbandi Could you take another pass at this PR? |
shizhMSFT
pushed a commit
to notaryproject/notation
that referenced
this pull request
Apr 20, 2023
This PR adds local sign/list/verification for OCI image layout directory. For RC.4: 1. It only supports storing the generated signature into the target OCI layout directory. 2. It supports listing signatures within the OCI layout directory. 3. It only supports verifying signatures within the target OCI layout directory. This PR is based on spec PR: #601 (Merged). This PR is dependent on the corresponding notation-go PR: notaryproject/notation-go#288. Please review the notation-go PR first. Resolves #283. Both remote registry and oci-layout scenario are tested. E2E tests are also included. --------- Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modified Registry and Notation packages to incorporate local sign and verification of OCI layout directory.
This PR targets the RC.4 release. (Note, support of OCI layout tarball will be included in future releases after RC.4.)