Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add local sign/list/verification for OCI layout directory #595

Merged
merged 61 commits into from
Apr 20, 2023
Merged

feat: add local sign/list/verification for OCI layout directory #595

merged 61 commits into from
Apr 20, 2023

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Mar 23, 2023 •
edited
Loading

This PR adds local sign/list/verification for OCI image layout directory.
For RC.4:

  1. It only supports storing the generated signature into the target OCI layout directory.
  2. It supports listing signatures within the OCI layout directory.
  3. It only supports verifying signatures within the target OCI layout directory.

This PR is based on spec PR: #601 (Merged).

This PR is dependent on the corresponding notation-go PR: notaryproject/notation-go#288.
Please review the notation-go PR first.

Resolves #283.

Both remote registry and oci-layout scenario are tested. E2E tests are also included.

@Two-Hearts
added local sign for oci layout folder
7370052 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added local verification for OCI layout folder
fa008ca 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
9ea0f18 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolved conflicts
4306629 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
3412287 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added local sign for descriptor.json
c4c5a8e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local
09651d3
@Two-Hearts
update
7493a51 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
58e3864 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local
34d0889
@Two-Hearts
Merge branch 'local' of https://github.com/patrickzheng200/notation i…
3612b4d 
…nto local
@Two-Hearts
Merge branch 'notaryproject:main' into local
a90819f
@Two-Hearts
added verification for descriptor.json
e9e0757 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'local' of https://github.com/patrickzheng200/notation i…
410617e 
…nto local
@Two-Hearts
update
06e400a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local
853eac1
@Two-Hearts
update
dfe8e91 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local
f16b4a6
@Two-Hearts
added local sign/verification on OCI layout directory
1f78788 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local-rc4
74cd415
@Two-Hearts
update e2e test
48180a5 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
refactored local sign/verification
27abde2 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
7f8e420 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fixed e2e tests
0b383a9 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added e2e
9c283aa 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added tests
8d2272e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix
42762ca 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix
31aaa8b 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added verify tests
70bea37 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
3c4ac54 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix test
1443c16 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fixed bug in experimental
2eb02b4 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local-rc4
9e3e70a
@Two-Hearts
Merge branch 'notaryproject:main' into local-rc4
8b18726
@Two-Hearts
updated based on spec
1c4378b 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into local-rc4
54583e4
@Two-Hearts
updated dependency as notation-go PR has been merged
9332d0f 
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
priteshbandi reviewed Apr 19, 2023
View reviewed changes
internal/osutil/file.go Outdated Show resolved Hide resolved
cmd/notation/inspect.go Outdated Show resolved Hide resolved
cmd/notation/internal/errors/errors.go Outdated Show resolved Hide resolved
cmd/notation/manifest.go Outdated Show resolved Hide resolved
cmd/notation/manifest.go Outdated Show resolved Hide resolved
cmd/notation/manifest.go Outdated Show resolved Hide resolved
cmd/notation/manifest.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
f6d1c1d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix
e39882d 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Apr 19, 2023
View reviewed changes
cmd/notation/sign.go Outdated Show resolved Hide resolved
priteshbandi
priteshbandi previously approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Two-Hearts
updated warning msg
529a6df 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 17d3525 into notaryproject:main Apr 20, 2023
@patrickzheng200 patrickzheng200 deleted the local-rc4 branch April 20, 2023 05:09
@patrickzheng200 patrickzheng200 mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@byronchien byronchien Awaiting requested review from byronchien

@qweeah qweeah Awaiting requested review from qweeah

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao JeyJeyGao is a code owner

Assignees

@patrickzheng200 patrickzheng200

Labels
enhancement New feature or request
Projects
None yet
Milestone
RC-4
Development

Successfully merging this pull request may close these issues.

notation sign/verify to work with local storage
9 participants
@patrickzheng200 @codecov-commenter @yizha1 @qweeah @priteshbandi @byronchien @shizhMSFT @JeyJeyGao @Two-Hearts