Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CODEOWNERS and MAINTAINERS files #370

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Updated CODEOWNERS and MAINTAINERS files #370

merged 2 commits into from
Jan 14, 2024

Conversation

toddysm
Copy link
Contributor

@toddysm toddysm commented Jan 11, 2024

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b315de4) 73.35% compared to head (5ce13d6) 73.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files          27       27           
  Lines        2492     2492           
=======================================
  Hits         1828     1828           
  Misses        524      524           
  Partials      140      140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NiazFK
NiazFK approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@NiazFK NiazFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddysm toddysm merged commit e56ee18 into notaryproject:main Jan 14, 2024
7 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Jan 24, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@NiazFK NiazFK NiazFK approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@toddysm @codecov-commenter @JeyJeyGao @NiazFK @Two-Hearts