Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: tag 1.1.0 #378

Closed
4 of 6 tasks
Two-Hearts opened this issue Jan 24, 2024 · 7 comments
Closed
4 of 6 tasks

vote: tag 1.1.0 #378

Two-Hearts opened this issue Jan 24, 2024 · 7 comments
Assignees

Comments

@Two-Hearts
Copy link
Contributor

Two-Hearts commented Jan 24, 2024

Release

This would mean tagging b7cd8a0 as v1.1.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-go v1.1.0.

Changes

The code changes compared to v1.0.1 include:

Full Changelog: v1.0.1...b7cd8a0

Action Requested

Please respond LGTM or REJECT (with reasoning).

@Two-Hearts Two-Hearts added enhancement New feature or request triage Needs evaluation for feasibility, timeline, etc. and removed enhancement New feature or request triage Needs evaluation for feasibility, timeline, etc. labels Jan 24, 2024
@JeyJeyGao
Copy link
Contributor

LGTM

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jan 24, 2024

LGTM

Should the commit be b7cd8a0?

@Two-Hearts
Copy link
Contributor Author

LGTM

Should the commit be b7cd8a0?

@shizhMSFT Nice catch. Updated. @JeyJeyGao could you re-vote for the release? Thanks.

@shizhMSFT
Copy link
Contributor

LGTM

2 similar comments
@JeyJeyGao
Copy link
Contributor

LGTM

@priteshbandi
Copy link
Contributor

LGTM

@Two-Hearts
Copy link
Contributor Author

Closing the issue as v1.1.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

6 participants