fix: improve plugin error message #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
requested review from
gokarnm,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
SteveLasker and
Two-Hearts
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 73.35% 73.25% -0.11%
==========================================
Files 27 27
Lines 2492 2516 +24
==========================================
+ Hits 1828 1843 +15
- Misses 524 533 +9
Partials 140 140 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Jan 15, 2024
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
reviewed
Jan 16, 2024
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
requested changes
Jan 16, 2024
Two-Hearts
reviewed
Jan 16, 2024
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PluginUnknownError,PluginValidityError,PluginDirectoryError. For each error types, Notation CLI should provide a recommanded suggestion to solve them.Resolve part of: notaryproject/notation#824
Resolve part of: notaryproject/notation#867
Signed-off-by: Junjie Gao [email protected]