Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uninstall to CLIManager #363

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

Two-Hearts
Copy link
Contributor

This PR adds Uninstall method to CLIManager.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ce0c457) 74.36% compared to head (b33af9d) 74.33%.

Files Patch % Lines
plugin/manager.go 66.66% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   74.36%   74.33%   -0.04%     
==========================================
  Files          24       24              
  Lines        2251     2260       +9     
==========================================
+ Hits         1674     1680       +6     
- Misses        457      459       +2     
- Partials      120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title feat: added uninstall to CLIManager feat: add uninstall to CLIManager Nov 23, 2023
@Two-Hearts Two-Hearts merged commit 5de0d58 into notaryproject:main Nov 23, 2023
7 checks passed
@Two-Hearts Two-Hearts deleted the plugin branch November 23, 2023 03:15
@Two-Hearts Two-Hearts mentioned this pull request Jan 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants