Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notation plugin uninstall command #842

Merged
merged 24 commits into from
Dec 5, 2023

Conversation

Two-Hearts
Copy link
Contributor

This PR is based on the spec PR: #809

It adds the notation plugin uninstall command.

Tests: The e2e test cases are also included in this PR.

Note: This PR depends on the notation-go PR: notaryproject/notation-go#363

Update: PR notaryproject/notation-go#363 has been merged.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Copy link
Contributor Author

This PR was reviewed here: #832, however, due to some GitHub issue, I accidently deleted the original branch and overwrite it with the current one (the contents of these two PRs are the same).

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 49d48bc into notaryproject:main Dec 5, 2023
5 checks passed
@Two-Hearts Two-Hearts deleted the plugin-uninstall branch December 6, 2023 03:04
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <[email protected]>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: rgnote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants