-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error messages of notation CLI #810
Conversation
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #810 +/- ##
==========================================
- Coverage 64.09% 64.05% -0.05%
==========================================
Files 40 40
Lines 2284 2323 +39
==========================================
+ Hits 1464 1488 +24
- Misses 698 709 +11
- Partials 122 126 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Patrick Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumping up to notation-go v1.0.1. As #810 is merged, bumping up build is successful now. --------- Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Bumping up to notation-go v1.0.1. As notaryproject#810 is merged, bumping up build is successful now. --------- Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Bumping up to notation-go v1.0.1. As #810 is merged, bumping up build is successful now. --------- Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Bumping up to notation-go v1.0.1. As #810 is merged, bumping up build is successful now. --------- Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Bumping up to notation-go v1.0.1. As notaryproject#810 is merged, bumping up build is successful now. --------- Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
Bumping up to notation-go v1.0.1. As notaryproject#810 is merged, bumping up build is successful now. --------- Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: rgnote <[email protected]>
This PR improves error messages of
notation sign
,notation verify
,notation list
, andnotation inspect
commands. The changes include:Note, this PR depends on notaryproject/notation-go#345. (On the notation CLI side, we are not displaying any individual signature error, only corresponding error messages are updated.)notaryproject/notation-go#345 has been merged. Notation CLI dependencies are up to date.
Resolves #699
Resolves #700
Resolves #701
Resolves #808