Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update dependencies #815

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Oct 31, 2023

Bumping up to notation-go v1.0.1.

Note: The build fails due to E2E test. Therefore, this PR depends on #810

As #810 is merged, bumping up build is successful now.

@JeyJeyGao
Copy link
Contributor

Looks like we need to update E2E testing?

@Two-Hearts
Copy link
Contributor Author

Looks like we need to update E2E testing?

Yes, as I mentioned, this is fixed in PR #810

priteshbandi
priteshbandi previously approved these changes Nov 1, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #815 (a787e0d) into main (bb2669b) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #815   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files          40       40           
  Lines        2323     2323           
=======================================
  Hits         1488     1488           
  Misses        709      709           
  Partials      126      126           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit ed70c9d into notaryproject:main Nov 3, 2023
8 checks passed
@Two-Hearts Two-Hearts deleted the bump-up branch November 3, 2023 02:11
Two-Hearts added a commit to Two-Hearts/notation that referenced this pull request Nov 3, 2023
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Bumping up to notation-go v1.0.1.
As #810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
Bumping up to notation-go v1.0.1.
As #810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <[email protected]>
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
6 tasks
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <[email protected]>
rgnote pushed a commit to rgnote/notation that referenced this pull request Mar 8, 2024
Bumping up to notation-go v1.0.1.
As notaryproject#810 is merged, bumping
up build is successful now.

---------

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: rgnote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants