Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: vdb_upload config values are ignored #1752

Closed
2 tasks done
dagardner-nv opened this issue Jun 24, 2024 · 0 comments · Fixed by #1813
Closed
2 tasks done

[BUG]: vdb_upload config values are ignored #1752

dagardner-nv opened this issue Jun 24, 2024 · 0 comments · Fixed by #1813
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

dagardner-nv commented Jun 24, 2024 •
edited
Loading

Version

24.06

Which installation method(s) does this occur on?

Source

Describe the bug.

The code attempts to merge configs originating from CLI flags and from the yaml config, with any CLI values taking precedence.

However there is a problem in that the default values are considered to be a part of the CLI values, thus the config values are never used.

Once resolved, the removal of the documentation for this in PR #1778 should be removed.

Minimum reproducible example

python examples/llm/main.py vdb_upload pipeline --stop_after=1024 --enable_cache --vdb_config_path=examples/llm/vdb_upload/vdb_config.yaml

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jun 24, 2024
@dagardner-nv dagardner-nv changed the title [BUG]: vdb_upload cli flags not being handled propperly [BUG]: vdb_upload config values are ignored Jun 24, 2024
dagardner-nv added a commit to dagardner-nv/Morpheus that referenced this issue Jun 28, 2024
@dagardner-nv
Remove documentation for yaml config files until nv-morpheus#1752 is …
3e92ce5 
…resolved
@dagardner-nv dagardner-nv mentioned this issue Jun 28, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 29, 2024
@dagardner-nv
Remove documentation for yaml config files in vdb_upload pipeline u…
94b7105 
…ntil #1752 is resolved (#1778)

* Morpheus issue #1752 renders the `--vdb_config_path` flag broken, remove it from documentation until the bug is resolved.
* Replace stubbed markdown `README.md` files for rag and vdb_upload pipelines with symlinks to the readme's in the examples dir.
* Replace broken link for generating NGC keys with https://docs.nvidia.com/ngc/gpu-cloud/ngc-user-guide/index.html#generating-personal-api-key which I believe is the correct url.
* Fix anchor urls in the vdb_upload readme

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1778
@dagardner-nv dagardner-nv self-assigned this Jul 12, 2024
@dagardner-nv dagardner-nv mentioned this issue Jul 12, 2024
Merged
@rapids-bot rapids-bot bot closed this as completed in ad915cb Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix merging of CLI args and Yaml configs in vdb_upload example dagardner-nv/Morpheus
1 participant
@dagardner-nv