Fix merging of CLI args and Yaml configs in vdb_upload example
#1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diferentiate the explicit cli args the user specified on the command line from the cli args which include default values the user didn't specify. Move default values out of the code blocks into globals Precedence is: Explicit cli args Yaml config (if there is one) Default cli args In the previous version there were conflicting docstrings over which takes precedence, however in practice CLI args took precenence, since there was no separation of the explicit vs default values in practice the yaml config was never used. Fix bug type-o causing yaml schema definitions to be ignored. Resulting code is 122 lines shorter
mdemoret-nv
approved these changes
Jul 24, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently CLI args always take precedence over Yaml config values, however since most of the CLI args have a default value in practice the Yaml config values are always ignored.
Precedence order:
Closes #1752
By Submitting this PR I confirm: