Remove pre-built container section from getting_started.md
#1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yczhang-nv
added
non-breaking
dagardner-nv
approved these changes
Jun 26, 2024
|
/merge |
dagardner-nv
added a commit
to dagardner-nv/Morpheus
that referenced
this pull request
Jul 9, 2024
…v-morpheus#1764)" This reverts commit ba23b31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The quickstart guide recommends users to use the pre-built containers, however these containers don't have the ability to launch Triton as documented.
Have tried the solution that adding
./external/utilities/docker/install_docker.shtoDockerfileto enable spinning up another docker container that runs triton server inside the release container, but it cannot mount/modelsdirectory due to the nested docker mount issue, making the solution to be invalid.For
24.06release, just remove the pre-built container section fromgetting_started.mdand let users to build the container from source. For further improvement, plan to publish a separate models container in the next release.Closes #1507
By Submitting this PR I confirm: