Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Docker image for Morpheus models #1804

Merged
merged 27 commits into from
Jul 25, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 8, 2024

Description

  • Create a models Docker image located at models/docker/Dockerfile along with a helper script models/docker/build_container.sh
  • Remove models from release container
  • Adjust examples documentation to use new image
  • Move the ransomeware models from examples/ransomware_detection/models into models/ransomware-models

Closes #552

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change feature request New feature or request skip-ci Optionally Skip CI for this PR labels Jul 8, 2024
@dagardner-nv dagardner-nv self-assigned this Jul 8, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners July 8, 2024 21:10
@dagardner-nv dagardner-nv marked this pull request as draft July 8, 2024 21:10
@dagardner-nv dagardner-nv marked this pull request as ready for review July 9, 2024 17:39
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 9, 2024 17:39
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label Jul 9, 2024
Copy link
Contributor

@raykallen raykallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followed the new readme instructions, and tested all the models in the new model container. lgtm

@mdemoret-nv
Copy link
Contributor

What should be the name of the container? I've been using morpheus-tritonserver-models

This works for me

How to version the container? I've been using just the Morpheus version, but we may consider adding the Triton version to the tag.

Tag it the same as the Morpheus version. While its possible to change the Triton version used, we do tie our releases to a specific Triton version

For unreleased versions (ex 24.10) should we:

Lets go with the "dont deploy" option. If it takes seconds, the barrier to entry is low. These containers are going to be large due to the models being included. Best to avoid pushing unnecessary alpha tags

.devcontainer/docker-compose.yml Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 79ed546 into nv-morpheus:branch-24.10 Jul 25, 2024
11 checks passed
@dagardner-nv dagardner-nv deleted the david-models-image branch July 25, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Publish a Morpheus models container
3 participants