Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add membership type field #123

Closed

Conversation

cttengsfmta
Copy link
Contributor

Add membership type field to the provider API. We presume that more values could be added to the list of membership types. (Reopening #106, as requested)

@cttengsfmta
Copy link
Contributor Author

More background on why we need this: optional field describes the general membership of the user taking the trip. The values and applicability would vary based by jurisdiction. Some programs allow members to sign up for subscription options (e.g., monthly or annual) in addition to paying as you go with a single ride fare. Additionally, SF’s programs have low-income options. Calculating total trips in the aggregate by type would be part of our regular reporting.

@hunterowens
Copy link
Collaborator

@cttengsfmta this looks good. We will also want to change the corresponding JSONSchema definitions for our validator codebases. Do you want to take a crack at that or should I?

@thekaveman thekaveman added the Schema Implications for JSON Schema or OpenAPI label Oct 10, 2018
@hunterowens
Copy link
Collaborator

I wonder how similar #126 and #76 are.

@cttengsfmta
Copy link
Contributor Author

I don't see a way to add a new Enum in generate_provider_schema.py

@alexdemisch
Copy link
Collaborator

To summarize the discussion from the 4/11 call, the current proposal would be to add the membership_type field, starting with the enum values proposed earlier. This would be an optional field. While this field does provide information related to the user of the trip, it is still generalized and not PII. There are concerns that an enumerated list of values may not be able to capture quickly changing business models that may introduce new membership types, so the enum values would need to be actively managed. An experimental prefix (e.g., “ex-“) could be used to allow new values not explicitly added to the list of enumerated values.

@hunterowens hunterowens added this to the 0.4.0 milestone Jun 28, 2019
@hunterowens
Copy link
Collaborator

moving this to 0.4.1 as an optional field.

@hunterowens hunterowens modified the milestones: 0.4.0 , 0.4.1 Oct 25, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jose Quinteiro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sarob sarob added the enhancement New feature or request label Dec 19, 2019
@sarob sarob added the Provider Specific to the Provider API label Dec 27, 2019
@hunterowens
Copy link
Collaborator

@dirkdk to rewrite based on discussion on 1/16 into a separate reporting / equity notes.

@thekaveman thekaveman modified the milestones: 0.4.1 , Future Jan 16, 2020
@thekaveman thekaveman mentioned this pull request Jan 16, 2020
@schnuerle schnuerle modified the milestones: Future, 1.0.0, 1.1.0 Jul 16, 2020
@schnuerle
Copy link
Member

Would like to revisit this idea for adding this info directly to the Provider API, in addition to potentially adding to a Metrics API #486.

@schnuerle schnuerle added the privacy Implications around privacy for the attention of the OMF Privacy Committee label Jul 16, 2020
@schnuerle schnuerle added the Metrics Related to the Metrics API and related topics label Aug 28, 2020
@schnuerle
Copy link
Member

This is being discussed as part of a subset of a proposed Metrics API with aggregated (not trip level) information about special groups in #569.

@johnclary johnclary mentioned this pull request Oct 2, 2020
@johnclary
Copy link
Contributor

I'm strongly opposed to adding attributes to trip records that describe the users taking trips.

@alexdemisch
Copy link
Collaborator

We've discussed some of this already in some of the Provider WG calls on Metrics, but I'd consider this specific proposal to add additional elements to the detailed trip data to be abandoned in favor of the aggregate "special groups" reporting in the Metrics #569.

The only reason it would've be collected at a detailed level would be to roll it up anyway, so #569 is a better way to do this.

@schnuerle
Copy link
Member

Closing this in favor of work on #569.

@schnuerle schnuerle closed this Oct 12, 2020
@schnuerle schnuerle removed this from the 1.1.0 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Metrics Related to the Metrics API and related topics privacy Implications around privacy for the attention of the OMF Privacy Committee Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants