Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access method #76

Closed
wants to merge 7 commits into from
Closed

Conversation

mattwigway
Copy link

Add an access_method to the trips file which details how a user unlocked a vehicle (see #71). I included all the ways I have ever unlocked a shared vehicle, as well as a few I've heard talked about (cash, call center, etc).

This will be particularly useful for understanding the use of pilots that allow people to access dockless mobility without smartphones.

@@ -95,6 +95,7 @@ Data: `{ "trips": [] }`, an array of objects with the following structure
| `trip_duration` | Integer | Required | Time, in Seconds |
| `trip_distance` | Integer | Required | Trip Distance, in Meters |
| `route` | Route | Required | See detail below |
| `access_method` | Enum | Required | How the user gained access to the vehicle |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to #access-methods here like we do for the other enum fields/tables?

Otherwise this looks great, and agreed it is a useful datapoint to have.

@thekaveman thekaveman added this to the Future milestone Sep 26, 2018
@hunterowens hunterowens closed this Oct 1, 2018
@hunterowens hunterowens reopened this Oct 1, 2018
@hunterowens
Copy link
Collaborator

@mattwigway can you take a look at @thekaveman's comments and we can hopefully merge soon.

@mattwigway
Copy link
Author

mattwigway commented Oct 1, 2018 via email

@mattwigway
Copy link
Author

@thekaveman @hunterowens done! Let me know if you need any more changes.

@thekaveman thekaveman changed the base branch from master to dev October 3, 2018 03:00
@hunterowens
Copy link
Collaborator

@mattwigway aplogies, we had to change the base branch from master to dev. Can you rebase again Sorry! 😭

@@ -125,6 +125,7 @@ Response: See the [`trips` schema][trips-schema] for the expected format.
| `trip_duration` | Integer | Required | Time, in Seconds |
| `trip_distance` | Integer | Required | Trip Distance, in Meters |
| `route` | GeoJSON `FeatureCollection` | Required | See [Routes](#routes) detail below |
| `access_method` | Enum | Required | Array of [access methods](#access-methods): how the user gained access to the vehicle |
Copy link
Contributor

@oderby oderby Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would there be a multiple access methods for a single trip? (Thinking comments should just say "One of access method...")

@mattwigway
Copy link
Author

I merged dev into my branch, solved the conflicts, and addressed @oderby's comment that there should be a single access method per trip (typo on my part).

@hunterowens
Copy link
Collaborator

this pull request needs to update JSONSchema as well.

@thekaveman thekaveman added the Schema Implications for JSON Schema or OpenAPI label Oct 10, 2018
@marie-x
Copy link
Collaborator

marie-x commented Jul 1, 2019

@hunterowens @thekaveman still a thing?

@hunterowens
Copy link
Collaborator

yeah, let me move the milestone on this. I think there was a similar PR from @cttengsfmta as well that we should get into 0.4.0

@hunterowens hunterowens modified the milestones: Future, 0.4.0 Jul 1, 2019
@hunterowens hunterowens modified the milestones: 0.4.0 , 0.4.1 Oct 25, 2019
@hunterowens
Copy link
Collaborator

moving to 0.4.1./

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sarob sarob added the enhancement New feature or request label Dec 19, 2019
@sarob sarob added the Provider Specific to the Provider API label Dec 27, 2019
@thekaveman thekaveman modified the milestones: 0.4.1 , Future Jan 16, 2020
@thekaveman
Copy link
Collaborator

Related to the discussion on #123 and based on discussion on the 1/16 call, @dirkdk will write up a proposal to start thinking about separate reporting / equity functionality.

@schnuerle schnuerle modified the milestones: Future, 1.1.0 Jul 16, 2020
@schnuerle
Copy link
Member

Would like to review this as part of the 1.1.0 release, added to Provider in addition to the proposed Metrics API #485. Similar to #123.

@schnuerle schnuerle added the privacy Implications around privacy for the attention of the OMF Privacy Committee label Jul 16, 2020
@schnuerle schnuerle added the Metrics Related to the Metrics API and related topics label Aug 28, 2020
@schnuerle
Copy link
Member

Closing this in favor of #569.

@schnuerle schnuerle closed this Oct 12, 2020
@schnuerle schnuerle removed this from the 1.1.0 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Metrics Related to the Metrics API and related topics privacy Implications around privacy for the attention of the OMF Privacy Committee Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants