Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing/lost event to provider spec #443

Closed

Conversation

jiffyclub
Copy link
Contributor

Explain pull request

This is a companion pull request to #429 to add a "missing"/"lost" event to the provider spec. My hope is to unblock #376 (/vehicles endpoint). I'm not at all sure I've done this correctly, so pointers appreciated.

It might also be worth noting that this event type would be changing to "unknown" in the future per @thekidder's suggestion in #271 (comment).

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

  • No, not breaking

This only adds a field so I don't think it's breaking, but not 100% sure on the conventions here.

Impacted Spec

Which spec(s) will this pull request impact?

  • provider

Additional context

Add any other context or screenshots about the feature request here.

@jiffyclub jiffyclub requested a review from a team as a code owner February 5, 2020 23:49
@jiffyclub jiffyclub requested a review from a team February 5, 2020 23:49
@sarob sarob added enhancement New feature or request Provider Specific to the Provider API labels Feb 6, 2020
@sarob sarob added this to the Future milestone Feb 6, 2020
@jiffyclub
Copy link
Contributor Author

jiffyclub commented Feb 13, 2020

Closing per discussion on the OMF Provider call today (2020-02-13), we'll skip adding missing/lost at this point since it'll be included in the overhaul of vehicle status/event type coming in 0.5.0 (see discussion in #271).

@jiffyclub jiffyclub closed this Feb 13, 2020
@jiffyclub jiffyclub deleted the provider-lost-event branch February 13, 2020 19:22
@schnuerle schnuerle removed this from the Future milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Provider Specific to the Provider API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants