Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geography - Feature Branch #582

Merged
merged 60 commits into from
Oct 12, 2020
Merged

Geography - Feature Branch #582

merged 60 commits into from
Oct 12, 2020

Conversation

schnuerle
Copy link
Member

Explain pull request

This PR is to see what changes between the Geography feature branch and the dev branch, and prepare it for merger once it's ready.

Is this a breaking change

  • No, not breaking

Impacted Spec

  • agency
  • policy
  • provider

Additional context

PR #499 is merged to a 'feature branch' in the MDS repo so we can see how it fits into the larger spec, allow the community and staff to do PRs against it, merge other related PRs into it, and see how it will fit into dev when it's ready with this PR.

@schnuerle schnuerle requested a review from a team September 30, 2020 14:00
@schnuerle schnuerle requested a review from a team as a code owner September 30, 2020 14:00
@schnuerle schnuerle added the Geography Items related to the Geography API label Sep 30, 2020
@schnuerle schnuerle linked an issue Sep 30, 2020 that may be closed by this pull request
@schnuerle schnuerle added this to the 1.1.0 milestone Sep 30, 2020
@schnuerle schnuerle marked this pull request as draft September 30, 2020 14:06
geography/README.md Outdated Show resolved Hide resolved
geography/README.md Outdated Show resolved Hide resolved
@schnuerle
Copy link
Member Author

schnuerle commented Oct 6, 2020

To do: Need to review the definitions and add to MDS schema.

@schnuerle
Copy link
Member Author

Added 5 examples and associated files. Each example has 2 files, one is the MDS JSON, and the other is the GeoJSON part of those files so that Github can make a preview of it in the browser.

I pulled them all from a real world city, Louisville, KY because 1) we needed a real city, 2) all of these GIS files are documented and available online as open data here and here, 3) many different geography_types are represented in the available files, and 4) I am familiar with this city and these files.

I'd like to add one more example file which is the location of Stops when it's available from the city online.

@schnuerle
Copy link
Member Author

I've added an example for 'stop' which uses Point instead of MultiPolygon. Are points allowed, or do all geographies have to be MultiPolygons? Points would seem to affect the ability for some policy actions and policy driven events if used.

@schnuerle schnuerle marked this pull request as ready for review October 12, 2020 15:03
@schnuerle schnuerle requested a review from a team October 12, 2020 15:03
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix minor typo.

geography/examples/README.md Outdated Show resolved Hide resolved
geography/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Geography Items related to the Geography API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Geography API from Policy API
4 participants