Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Geography API from the Policy API #499

Conversation

janedotx
Copy link
Contributor

@janedotx janedotx commented May 16, 2020

Originally the Policy API included the Geography API, because Policy needed Geography objects.
As other proposed services (e.g. Jurisdiction API) are introduced, Geography really should be its own thing.

UPDATE

PR #499 is merged to a 'feature branch' in the MDS repo so we can see how it fits into the larger spec, allow the community and staff to do PRs against it, merge other related PRs into it, and see how it will fit into dev when it's ready with PR #582.

See the 'feature-geography' branch for details.

@janedotx janedotx requested a review from a team as a code owner May 16, 2020 01:40
@CLAassistant
Copy link

CLAassistant commented May 16, 2020

CLA assistant check
All committers have signed the CLA.

…tion/release-1.0.0

Release 1.0.0 - Tech Council Review
@marie-x marie-x changed the title Add geography service Extract Geography API from the Policy API Aug 13, 2020
@schnuerle schnuerle linked an issue Aug 26, 2020 that may be closed by this pull request
@janedotx janedotx requested a review from a team September 3, 2020 05:14
@schnuerle
Copy link
Member

schnuerle commented Sep 10, 2020

From the Working Group call today. Slides from today.

  • /geographies use cases. Is it needed?
    • Caching - so providers and third parties can download it all at once.
    • Searching - so you can see all geographies at once and how they relate before asking for details on the one you need from another API.
    • Adding geoJSON fields would make it too unwieldy.
    • Agreed for now it's useful and keep as is.
  • Previous Geographies
    • this is written now so these never become 'inactive', they just may not be referenced any more.
    • Warrants a new section that elaborates on the nuance and implementation here.
    • Need to check on city capacity to implement this and update
      • noted that Geography is already in Policy, so if a city is implementing Policy, they can handle the new Geography endpoint.
      • complexity comes from the prev_geographies - could be hard to keep things up to date
      • WGSC and OMF can do some outreach to cities and Policy Webinar attendees to ask about challenges
      • third parties can alleviate these concerns. Eg, in Louisville one employee just managed existing GIS files and one spreadsheet, and Stae took care of translating and publishing to Policy API.
  • Type of Geography field
    • Currently is meant to just be the definition of an area to be used elsewhere
    • Use can always be found elsewhere in other APIs
    • Use cases could be to pass in a variable and return just those on /geographies, find specific geographies like city boundaries or parking spots, Metrics to get relevant areas
    • Discussion if it exists to make an enumerated list of value, or maybe some kind of tagging system, or freeform.
    • For now leave it out, but could be added later if other endpoints need it
  • Public feed
    • Could be made public (non-authenticated) since there is no sensitive info here
    • Along with Policy, could be very useful for third party apps, new operators in a city
    • Needs to be accurate and stay up to date

@schnuerle schnuerle changed the base branch from dev to feature-geography September 10, 2020 20:54
}
```

_Note: A simple tool to validate `geographies.json` will be contributed to the Open Mobility Foundation._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this note be included now? How close to being ready is this tool? It may take some time to contribute to a tool to the OMF.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss. I don't have a good answer. Perhaps it's trivial now that @thekaveman made a schema?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just cut it for now so we can get this into the feature branch in OMF. The schema helps, and I'm not sure what this simple tool would be otherwise.

@@ -0,0 +1,150 @@
# Mobility Data Specification: Geography

This specification contains a collection of RESTful APIs used to read Geographies (descriptions of geographical information, e.g. multi-polygons, currently represented via GeoJSON).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are geographies always single or multi polygons? They will never be a line or point right? Either way we should clarify this somewhere in the spec. For an example, #480 assumes only polygons.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FeatureCollection is the highest-level concept. You can include lines and points but they are no-ops because they can't contain points. We will revisit once we have a curb spec.

@schnuerle schnuerle added this to the 1.1.0 milestone Sep 22, 2020
@@ -31,6 +31,8 @@ The Mobility Data Specification (**MDS**), a project of the [Open Mobility Found

* The [`policy`][policy] API endpoints are intended to be implemented by regulatory agencies and consumed by mobility providers. Providers query the Policy API to get information about local rules that may affect the operation of their mobility service or which may be used to determine compliance. It was first released in October 2019. Development takes place under the guidance of the OMF's City Services Working Group.

* The [`geography`][geography] API endpoints are intended to be implemented by regulatory agencies and consumed by mobility providers. Providers query the Policy API to get information about geographical regions for regulatory and other purposes. It was first released in October 2019, originally included as part of the Policy specification. Development takes place under the guidance of the OMF's City Services Working Group.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new endpoint, the title line should now be "MDS is currently comprised of four distinct components"

Copy link
Collaborator

@marie-x marie-x Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good catch. Fixed.

@schnuerle schnuerle merged commit 3cfe0cc into openmobilityfoundation:feature-geography Sep 29, 2020
@schnuerle
Copy link
Member

Merging this to the feature branch so we can look at it holistically, make edits and suggestions, and incorporate other related issues/PRs before we agree on the spec and merge to dev.

@schnuerle
Copy link
Member

PR #499 is merged to a 'feature branch' in the MDS repo so we can see how it fits into the larger spec, allow the community and staff to do PRs against it, merge other related PRs into it, and see how it will fit into dev when it's ready with PR #582.

See the 'feature-geography' branch for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Geography API from Policy API
5 participants