Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics - Feature Branch #587

Merged
merged 55 commits into from
Dec 9, 2020
Merged

Metrics - Feature Branch #587

merged 55 commits into from
Dec 9, 2020

Conversation

schnuerle
Copy link
Member

Explain pull request

This PR is to see what changes between the Metrics feature branch and the dev branch, and prepare it for merger once it's ready.

Is this a breaking change

  • No, not breaking

Impacted Spec

  • agency
  • policy
  • provider

Additional context

PRs #486 and #487 were merged to a 'feature branch' in the MDS repo so we can see how it fits into the larger spec, allow the community and staff to do PRs against it, merge other related PRs into it, and see how it will fit into dev when it's ready with this PR.

@schnuerle schnuerle requested a review from a team as a code owner October 16, 2020 19:32
@schnuerle schnuerle added the Metrics Related to the Metrics API and related topics label Oct 16, 2020
@schnuerle schnuerle added this to the 1.1.0 milestone Oct 16, 2020
@schnuerle schnuerle mentioned this pull request Oct 16, 2020
@schnuerle schnuerle marked this pull request as draft October 16, 2020 22:00
This was linked to issues Oct 16, 2020
@schnuerle schnuerle self-assigned this Oct 16, 2020
@schnuerle
Copy link
Member Author

schnuerle commented Oct 19, 2020

Here are the relevant notes from the WG Call last week.

Metrics

  • See previous presentation on this
  • Authorization should be the same as Agency, eg JWT.
  • Scenarios:
    • Cities can serve API to expose aggregated report data to trusted parties: eg, departments with their city, researchers.
    • Cities can serve API to provide data back to Providers to ensure alignment on counts for billing, enforcement, policy alignment.
    • Providers can serve API to cities. Bird asked for this previously. Note this would not be a replacement for /trips. (In addition, Special Groups can be used for this.)
  • Need to add the above clarifications to the proposal, including who hosts the file in which scenario.
  • Add not saying this does not replace the requirement for disaggregated data, but it may solve some of the same use cases.
  • Cities can opt into the Metrics endpoint from Providers
  • Need to take this conversation to other OMF committees. Will present to Privacy Committee at meeting next Wednesday. Will discuss at WGSC Checkpoint next Friday.

@whereissean
Copy link
Contributor

@schnuerle I combined the requested updates to Metrics in a new PR #594 against this branch.

Add geography and authentication to Metrics feature branch
@schnuerle
Copy link
Member Author

Still to do:

  1. Add beta tag and link in section of main page
  2. Figure out k-anonymity values
  3. Add revised special groups language.

Copy link
Member Author

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed revision of this language from our WG discussion, drafted by @joshuaandrewjohnson1 at Spin:

"Other special group types may be added in future MDS releases as relevant agency and provider use cases are identified. When additional special group types or metrics are proposed, a thorough review of utility and relevance in program oversight, evaluation, and policy development should be done by OMF Working Groups, as well as any privacy implications by the OMF Privacy Committee."

Welcome feedback on this wording.

Updated here

@schnuerle
Copy link
Member Author

Beta feature language added as section on main Metrics spec page.

The only punch list item left is research and recommendations on changes to k-values.

@schnuerle
Copy link
Member Author

I'm going to make changes based on the city and WG discussions, removing the provider scenario and special groups.

@schnuerle schnuerle marked this pull request as ready for review December 9, 2020 23:40
@schnuerle schnuerle merged commit 2eced1d into dev Dec 9, 2020
@schnuerle schnuerle deleted the feature-metrics branch January 26, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metrics Related to the Metrics API and related topics privacy Implications around privacy for the attention of the OMF Privacy Committee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special groups aggregate metrics Add an MDS Metrics API
5 participants