Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geography and authentication to Metrics feature branch #594

Conversation

whereissean
Copy link
Contributor


name: Default
about: Suggest changes to MDS
title: Add geography and authentication to Metrics feature branch


MDS Pull Request

Thank you for your contribution! Please review our OMF contributing page to understand guidelines and policies for participation, and our Code of Conduct page.

To avoid complications and help make the Review process as smooth as possible, make sure to:

  1. Target dev branch. Please ensure you are targeting dev, not main.
  2. Keep the "Allow edits from maintainers" button checked to help us resolve some issues for you.
  3. Be ready to resolve any merge conflicts before we approve your Pull Request.
  4. Have an up to date profile, per our Github community profile guildance.

Explain pull request

Updates requested by @schnuerle for features-metrics. Add geography and authentication to Metrics feature branch.

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

  • Yes, breaking
  • No, not breaking
  • I'm not sure

Impacted Spec

Which spec(s) will this pull request impact?

  • metrics

Additional context

Add any other context or screenshots about the feature request here.

@whereissean whereissean requested a review from a team as a code owner October 29, 2020 05:30
@schnuerle schnuerle added Agency Specific to the Agency API Metrics Related to the Metrics API and related topics privacy Implications around privacy for the attention of the OMF Privacy Committee Provider Specific to the Provider API labels Oct 31, 2020
@schnuerle schnuerle added this to the 1.1.0 milestone Oct 31, 2020
@schnuerle
Copy link
Member

Thanks @whereissean this looks great!

Still to do:

  1. Add beta tag and link in section of main page
  2. Figure out k-anonymity values
  3. Add revised special groups language.

I can do 1 and 3 once merged to feature branch.

@schnuerle schnuerle merged commit 88299f3 into openmobilityfoundation:feature-metrics Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Metrics Related to the Metrics API and related topics privacy Implications around privacy for the attention of the OMF Privacy Committee Provider Specific to the Provider API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants