Use correct has_arg when parsing command line options with getopt_long #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getopt_long
takes an array ofstruct option
to represent recognized command line options.struct option
has a fieldhas_arg
which specifies whether or not the command line option has an associated argument; possible values are:no_argument
: no argument to the option is expectedrequired_argument
: an argument to the option is requiredoptional_argument
: an argument to the option may be presentedWe've been incorrectly setting this field to
optional_argument
in some cases when the intent was to make the command line option itself optional. This PR setshas_arg
torequired_argument
where appropriate, and adds logic to ensure that required options are passed.