Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 support for kubectl #28

Closed
galovics opened this issue Jan 31, 2024 · 5 comments
Closed

ARM64 support for kubectl #28

galovics opened this issue Jan 31, 2024 · 5 comments
Assignees

Comments

@galovics
Copy link
Contributor

Currently the architecture is hardcoded in the download URL for kubectl at https://github.com/oracle-actions/configure-kubectl-oke/blob/main/src/main.ts#L27

An extra parameter could be added to configure the target architecture, defaulting to amd64 to not break any existing usage of the action.

@Djelibeybi Djelibeybi self-assigned this Jan 31, 2024
@Djelibeybi
Copy link
Member

Good suggestion, thanks.

@Djelibeybi
Copy link
Member

I guess it would be better to populate this based on the architecture of the runner on which the action is currently running as opposed to requiring the user to configure it correctly.

@galovics
Copy link
Contributor Author

galovics commented Feb 1, 2024

@Djelibeybi agreed. I was just thinking of the configuration (after spending a good amount of time) to make this as easy to implement as possible.

In the meantime, I came across the setup-helm action as well and I saw those guys have implemented it. Probably copying it would be the easiest.

https://github.com/Azure/setup-helm/blob/main/src/run.ts#L110

galovics added a commit to galovics/configure-kubectl-oke that referenced this issue May 28, 2024
@galovics
Copy link
Contributor Author

@Djelibeybi had some spare time, did a PR, pls take a look: #31

galovics added a commit to galovics/configure-kubectl-oke that referenced this issue May 29, 2024
@Djelibeybi
Copy link
Member

Closed via #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants