-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM64 support for kubectl #28
Comments
Good suggestion, thanks. |
I guess it would be better to populate this based on the architecture of the runner on which the action is currently running as opposed to requiring the user to configure it correctly. |
@Djelibeybi agreed. I was just thinking of the configuration (after spending a good amount of time) to make this as easy to implement as possible. In the meantime, I came across the setup-helm action as well and I saw those guys have implemented it. Probably copying it would be the easiest. https://github.com/Azure/setup-helm/blob/main/src/run.ts#L110 |
@Djelibeybi had some spare time, did a PR, pls take a look: #31 |
Closed via #35 |
Currently the architecture is hardcoded in the download URL for kubectl at https://github.com/oracle-actions/configure-kubectl-oke/blob/main/src/main.ts#L27
An extra parameter could be added to configure the target architecture, defaulting to amd64 to not break any existing usage of the action.
The text was updated successfully, but these errors were encountered: