Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28: Support non-x86 architecture #31

Closed
wants to merge 1 commit into from

Conversation

galovics
Copy link
Contributor

No description provided.

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 28, 2024
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels May 29, 2024
@Djelibeybi
Copy link
Member

I'm on leave until early June, so I'll take a look next week. In the meantime, please remove the .js file from the PR, just leave the TypeScript file.

@galovics
Copy link
Contributor Author

Will do @Djelibeybi, wasn't sure if that's needed so did the bundle generation anyway.

@Djelibeybi
Copy link
Member

It may be worth waiting until I merge #32 which retrofits some CI stuff and bumps a bunch of dependencies to newer versions too.

@galovics
Copy link
Contributor Author

@Djelibeybi sure thing, let me know when there's something to do for this PR.

@Djelibeybi
Copy link
Member

Sorry for the delay. I'm just in the middle of some internal changes which have resulted in the testing tenancy for these actions going away. I'm trying to find a replacement tenancy so that we can test these changes before merging.

@galovics
Copy link
Contributor Author

galovics commented Jun 6, 2024

alright, thanks for the update

@Djelibeybi
Copy link
Member

Merged via #35

@Djelibeybi Djelibeybi closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Development

Successfully merging this pull request may close these issues.

3 participants