-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates related to polymake 4.12 #3819
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3819 +/- ##
==========================================
- Coverage 83.96% 83.96% -0.01%
==========================================
Files 591 591
Lines 81384 81402 +18
==========================================
+ Hits 68335 68346 +11
- Misses 13049 13056 +7
|
I think it would make sense to split this PR into two: one regarding the small fixes for polymake 4.12 (which seems to be almost finished) and a separate one for the post functionality. |
That makes sense, I will split this up. |
The error in CI seems like something real: https://github.com/oscar-system/Oscar.jl/actions/runs/9927077065/job/27421571688?pr=3819#step:9:3937 |
Yes, I am aware of that, there are some extra conversion helpers missing for Pair/Tuple types, I need to add them in Polymake.jl. (The reason is that on Linux CxxLong is just an alias for Int64, but on macOS CxxLong is a separate type, and then some default constructions don't match as expected) |
todo:
add wrappers for some poset functionalityWIP: polymake posets #3928